Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding check_binaries command that is distinct from check_packages to lib/common.sh #745

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Adding check_binaries command that is distinct from check_packages to lib/common.sh #745

merged 1 commit into from
Jun 24, 2019

Conversation

pswica
Copy link
Contributor

@pswica pswica commented Jun 23, 2019

My motivation for this PR comes from this issue here: #684

Specifically, for many prerequisites that the scripts here require, we check whether a distribution-specific package for them exists. So, for example, if I install the jq binary from source, common::check_packages jq would fail even though I'm using Ubuntu simply because I didn't install using apt.

Requiring that binaries come from specific packages causes problems when the packages that contain those binaries changes, or is different between Linux distribution. It also prevents non-mainstream, and non-Linux-based distros, from using these scripts. I think checking for binaries, directly, is much for flexible.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 23, 2019
dougm
dougm reviewed Jun 24, 2019
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, much more flexible to check for this set of binaries rather than insist a specific package is installed and to just leave the package as a suggested way to install the binary.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougm, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@pswica
Copy link
Contributor Author

pswica commented Jun 24, 2019

Thanks a lot for your review @dougm. Can I get an okay-to-test?

@dougm
Copy link
Member

dougm commented Jun 24, 2019

/ok-test-test

@justaugustus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit e3fb009 into kubernetes:master Jun 24, 2019
@pswica pswica mentioned this pull request Jun 26, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@claurence claurence Awaiting requested review from claurence

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dougm dougm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pswica @k8s-ci-robot @dougm @justaugustus